Aung-Phone-Naing / pe

0 stars 0 forks source link

Error in Adding Mechanism Sequence Diagram #16

Open Aung-Phone-Naing opened 1 year ago

Aung-Phone-Naing commented 1 year ago

As shown below, the activation bar for ExpenseManager should be extended till the "X".

image.png

image.png

soc-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error in activation bar for Adding Mechanism in Sequence Diagram

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


As shown below, the activation bar of Expense should be extended until its termination "X" instead.

image.png

image.png


[original: nus-cs2113-AY2223S2/pe-interim#977] [original labels: severity.VeryLow type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

I do not think that this is a flaw. The termination simply shows that the Expense will eventually deleted and hence the activation bar extending until its deleting is rather meaningless. Also, in the platform that I used to draw this diagram I believe configuring such is impossible.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.IssueUnclear`] - [x] I disagree **Reason for disagreement:** The issue can clearly be remedied by the team as shown on the Parser class where they put the "X" right at the end of the activation bar, however for the case of the ExpenseManager the team fails to do so and they claim that the platform they use is unable to to configure the arrangement when they clearly have done so for the other class. Hence this remains to be a bug that should be resolved.