search

Aung-Phone-Naing / pe

0 stars 0 forks source link

Sequence diagram for Pay mechanism contains error for FutureExpense #21

Open Aung-Phone-Naing opened 1 year ago

Aung-Phone-Naing commented 1 year ago

AS shown the activation bar for FutureExpense ends before the "X" which is wrong. image.png

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error in activation bar for Adding Mechanism in Sequence Diagram

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

As shown below, the activation bar of Expense should be extended until its termination "X" instead.

image.png

image.png

[original: nus-cs2113-AY2223S2/pe-interim#977] [original labels: severity.VeryLow type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

I do not think that this is a flaw. The termination simply shows that the Expense will eventually deleted and hence the activation bar extending until its deleting is rather meaningless. Also, in the platform that I used to draw this diagram I believe configuring such is impossible.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: While the issue duplicated speaks of putting the "X" for the initialization activation bar of a class, the issue I have raised focuses more on a documentation error that could be remedied as shown on the class diagram in the issue that they have raised as duplicate. As shown in the diagram below, for the Parser class the team clearly did the right thing by putting the "X" at the end of the last activation bar for the class, however they fail to do so for the ExpenseManager class as well.

delete.png

## :question: Issue response Team chose [`response.IssueUnclear`] - [x] I disagree **Reason for disagreement:** As stated in my previous response to "duplicate status", it is clear that the team understands that the "X" should be placed at the end of the activation bar from how they illustrated in the Parser class, and hence my argument still stands that the activation bar for FutureExpense should end at the "X" instead.