AuraDevelopmentTeam / BungeeChat2

A new way to send private, global or help messages and to do much more with chatting network wide!
https://www.spigotmc.org/threads/bungee-chat.93960
GNU General Public License v3.0
64 stars 43 forks source link

Anti-Spam don't work #160

Closed AymerickA closed 4 years ago

AymerickA commented 4 years ago

Issue Description:

Anti-Spam (per minute) don't work, I have try with a player with no bypass permission of course and I have set at 8 messages per minutes and try many times and the player was not blocked.

At the same time, I've been testing the Anti CAPS LOCK and the expireAfter of Anti Duplication and that work perfectly. It's only the Anti spam don't work.

It could be interesting to make a classic anti-spam that obliges to send a message every 5 seconds for example (with config.conf).

Steps to reproduce:

  1. Set anti spam to true
  2. Spam more messages

Affected Versions:

Pastebin (but not very util here) : Chat spamming : http://prntscr.com/swfyl1 Config.conf : http://prntscr.com/swfz88

AymerickA commented 4 years ago

And no errors in logs

AwesomestCode commented 4 years ago

Please note that anti-spam can allow you to send messages in quick succession, but will only reset after sixty (60) seconds and thereinafter allow for you to send more messages.

BrainStone commented 4 years ago

To be a bit more precise it limits the messages to however many you configured in the config within the last 60.
Like if you reach the limit within 10 seconds (and the messages can be sent however fast you want during that time) you can't write a single message within the next 50 seconds. But then you'll get the messages back just as fast you wrote them.

Now what would be useful if you had chat logging enabled and you sent me that log so I can see the timing of the messages.

AymerickA commented 4 years ago

Yes I had understood the 60 seconds system very well, that's not the problem, it's that despite the max/second message count reached, players could still spam.

For example: https://pastebin.com/LwKnkF4G https://pastebin.com/meFhBg82

BrainStone commented 4 years ago

I can confirm the bug. Will work on it. Thanks for reporting!

BrainStone commented 4 years ago

The fix will be here in about 5 minutes: https://maven.aura-dev.team/repository/auradev-snapshots/dev/aura/bungeechat/BungeeChat/2.2.4.1258-DEV/BungeeChat-2.2.4.1258-DEV.jar

AymerickA commented 4 years ago

Thanks, I'll try that.

I take advantage of having you to understand the few settings that don't have a wiki or #comments or github.

On Anti-Swear : leetSpeak and freeMatching

I'm hoping that leetSpeak would be a setting that allows the player to send the message but only for him and the staff (with permission).

This would allow players who disparage the server or other players to still think that their message is being sent to everyone but in reality only the staff can see it.

For example: Player1 say "this is server is laggy and bad"

Player2 don't see the message of Player1 BUT Staff1 see the message

BrainStone commented 4 years ago

What LeetSpeak means: https://en.wikipedia.org/wiki/Leet

AymerickA commented 4 years ago

Oh ok and for freeMatching ?

And can you considerer my idea : "I'm hoping you add option on anti swea would be a setting that allows the player to send the message but only for him and the staff (with permission).

This would allow players who disparage the server or other players to still think that their message is being sent to everyone but in reality only the staff can see it.

For example: Player1 say "this is server is laggy and bad"

Player2 don't see the message of Player1 BUT Staff1 see the message"

AwesomestCode commented 4 years ago

Hmmm... I think you mean something like shadowmuting, is that correct? I worked on something like that, Spigot side, a while back to help stop spam bots, though using it on actual players seems borderline unethical.

BrainStone commented 4 years ago

Move the suggestion to a new issue please. And freeMatching means that the words to censor don't have to be full words.

AymerickA commented 4 years ago

@AwesomestCode

It's not the same goal, on my side it's just to stop 12 year old kids who stupidly insult other players and criticize the server without building with arguments.

AwesomestCode commented 4 years ago

I hate it when people use age to discriminate based on players. But yes, I do get your point. Please continue discussing in the new issue.