AuraDevelopmentTeam / BungeeChat2

A new way to send private, global or help messages and to do much more with chatting network wide!
https://www.spigotmc.org/threads/bungee-chat.93960
GNU General Public License v3.0
65 stars 43 forks source link

Compatibility with snap on Velocity #197

Closed Folas1337 closed 2 years ago

Folas1337 commented 2 years ago

Issue Description:

When using BungeeChat through snap on Velocity I can't use BungeePerms prefixes/suffixes (and probably more). According to @BrainStone this is an issue in snap and could be fixed somehow.

What happens:

I can unfortunately not use information of BungeePerms in BungeeChat.

What you expected to happen:

Being able to use this information to be displayed in BungeeChat.

Steps to reproduce:

  1. Download Velocity
  2. Install snap
  3. Install BungeeChat in snap
  4. Try using any information from BungeePerms to display in BungeeChat

Affected Versions:

Your most recent log or stack trace file where the issue was present:

Relevant logs:

[20:47:05] [Velocity Async Event Executor - #0/INFO]: Loaded plugin BungeeChat version 2.2.4.1354-DEV by BrainStone
[20:47:05] [Velocity Async Event Executor - #0/INFO]: ---------------- Bungee Chat ----------------
[20:47:05] [Velocity Async Event Executor - #0/INFO]: Authors: BrainStone, shawn_ian
[20:47:05] [Velocity Async Event Executor - #0/INFO]: Version: 2.2.4.1354-DEV
[20:47:05] [Velocity Async Event Executor - #0/INFO]: Modules: Alert, AntiAdvertising, AntiCapslock, AntiDuplication, AntiSpam, AntiSwear, ChatLock, ChatLogging, ClearChat, GlobalChat, HelpOp, Ignoring, JoinMessage, LeaveMessage, LocalTo, MOTD, Muting, Spy, StaffChat, WelcomeMessage
[20:47:05] [Velocity Async Event Executor - #0/INFO]: Contributors: AwesomestGamer, Brianetta, CryLegend, gb2233, Hodel1, Luck, MineTech13, n0dai
[20:47:05] [Velocity Async Event Executor - #0/INFO]: Translators: 47429921, Cantibra, DardBrinza, Fantasenf, fjeddy, Garixer, gb2233, Itaquito, LUKISO2, marzenie, Maxime_74, Misterio77, povsister, Totten98
[20:47:05] [Velocity Async Event Executor - #0/INFO]: Donators: Breantique, NickT
[20:47:05] [Velocity Async Event Executor - #0/INFO]: ---------------------------------------------
[20:47:05] [Velocity Async Event Executor - #0/INFO]: Enabled plugin BungeeChat version 2.2.4.1354-DEV by BrainStone
BrainStone commented 2 years ago

Issue is that the ProxyServer.getInstance().getPluginManager().getPlugin(pluginName) call doesn't return the plugin through snap.
It can be solved by adding a config option to forcefully enable permission modules.