Koodikatselmointi

[Badding]

Release 1 downloaded on Friday 26.4 00:15

issues

Methods

• In the UI class, main_loop and setup_menu are both very long functions. Separate them to smaller pieces
• Consider the clean code guidelines about naming the class methods and variables that are only used inside the class (_ or __ in front of the method)
• simulation speed: function to change the speed, does not use the speed parameter. Was the idea to change the tick rate to adjust the game speed?

Classes

• files highlife and life are almost identical. I think you had the idea to use "Ruleset" as the super class then life and highlife inherit that class, but for some reason it's not implemented that way?
• I'd probably move the variable for checking is the simulation running to the game logic class
• Separate gliders, blinkers and glider_gun from UI to their own classes

Clean code

• I know that the project doesn't have to be commented at this point of the project, but for example in the UI class, many of the comments are unnecessary and do not add any readability value.
• are there any tests for universe class? even though it's accessed from outomaatti_service, Should probably add some tests?

improve ideas

• pressing down the mouse button creates lines of cells
  • event loop checks if mouse is down and if the cell under the cell is not changed previously, change it
• pre-selected patterns that player can use, for example patterns that move in certain directions or ripple outwards, like at the start of the game (similar as in software requirements), but I'd add some interesting patterns that work.
• Stat for longest non-repeating chain reaction. This one might be hard to implement.
• different cells types:
  • black hole that pulls other nearby cells closer
  • collect list of cells near the back hole, and move them towards the black hole
  • spawner that create cells
  • create random cell near the spawner
  • cells that move and eat other cells to grow and shrink if they do not eat
  • cell moves towards the closest cell

Other stuff

Overall it's an interesting and ambitious idea, that has good basic functionality. Just needs missing features and minor tweaks to to achieve "cleaner code". Also chop the large functions with over 100 lines to smaller ones for better readability. Honestly this might felt a bit nit-picky, because it's a great project and most it's missing is polish. Good job!

[Aurala]

Thank you for the feedback! Fortunately most of this was on my todo list already.

Good ideas for the further development. The pre-selected patterns is in the original requirements (to implemented during this week), but the rest has to wait until the end of course. :)