search

Aurealis-Graphics / Lux-Shader

A Minecraft shader pack based on the popular BSL shader pack, adding quality of life additions and tweaks.
https://techdevongithub.github.io/Lux
77 stars 5 forks source link

1.18.2 using Fabric/Iris 1.2.6 and Lux-EA-B2-P1.zip - Enderman overlaid with black rectangle #4

Closed Geethebluesky closed 2 years ago

Geethebluesky commented 2 years ago

Hi! I'm not sure what kind of info you need for shader bug reports or if this is related to the other issue I see on this github.

I tried your shaders since Iris has it on their list of fully-compatible ones. Except whenever I see an enderman, it's overlaid with a giant black rectangle (probably because the mob was a few blocks away from me while attacking).

What do you need: hardware report? screenshot? logs (which)? Resource packs? Mod list/versions? Reproducing with a barebones set of mods (which--Fabric, Sodium/Iris and your shaders alone, or...?)

Thanks for your patience with me not knowing this in advance.

TechDevOnGitHub commented 2 years ago

Hey, thank you for reaching out!

it's overlaid with a giant black rectangle

What you are describing seems to be an issue with NaNs. I will be adding this issue to my personal list of current bugs and hopefully fix it until the next release. In the meantime, you should be able to reduce the issue by turning off Bloom in "Post Effects > Bloom: OFF"

What do you need: hardware report? screenshot? logs (which)? Reso...

For this specific issue all I'd need is a screenshot (which is now not necessary anymore due to your description of the issue) and what hardware, specifically what GPU driver you have installed. Mods can also impact the shader and introduce potential bugs, but it's not needed for this specific issue.

I will be creating an issue template for this repository now that the shader is getting more attention on GitHub.

Geethebluesky commented 2 years ago

I'm on Nvidia Game-ready drivers 511.65 on a GeForce 1070 (not Ti).

I can try updating the drivers if you think that might make a difference. Thanks!

TechDevOnGitHub commented 2 years ago

Making sure you're up-to-date is generally a good idea before reporting a bug but it's not necessary.

If you do end up fixing it by updating your drivers, please let me know so I can put this bug on a lower priority, otherwise I'll get it fixed as soon as possible.

TechDevOnGitHub commented 2 years ago

Hey, so thanks to @Lolothepro I have come across this issue.

If this really only happens in Iris and not OptiFine, the fix described there might resolve the issue, which would mean it's not an issue with the shader, but with Iris instead.

Geethebluesky commented 2 years ago

I finally have more than one day to play so I'm updating my drivers and will try to see if my (or any) resource pack is the cause. I use PueBDCraft but I'll check Faithful out for this.

I'm on Fabric so I can't really test Optifine, but this happened on a brand new profile with just Sodium, Iris 1.2.6, your shaders, and the PureBDCraft resource pack. It started happening when I loaded the respack, the mob displays fine on vanilla textures. And only when the enderman is looking at me, when he's sideways I can see his outline but he gets replaced with a black rectangle when his eyes are visible.

Edit, I switched to one of the SEUS Renewed shaders and added the respack, and the issue doesn't occur. Enderman lost the glow to his eyes though, looks like a basic texture from the respack.

I also tried with Faithful respack and got the same results.

I'll set up a Forge profile just to see what's going on there (am curious.)

Geethebluesky commented 2 years ago

Ok, I just installed Forge with Optifine, versions 40.0.24 and OptiFine_1.18.2_HD_U_H7.jar (which states it supports that version of Forge), and the install was a pain in PolyMC but that's another issue. :)

I loaded your shader and with the default texture pack everything's fine. I do see the rectangle when I load either resource pack (PureBDCraft or Classic Faithful) however.

To be clear I am using zero other mods here.

Does this help?

TechDevOnGitHub commented 2 years ago

This did help, in fact, even though I couldn't properly reproduce this issue, but it very well might be related to https://github.com/TechDevOnGitHub/Lux-Shader/commit/da29b1f90d3695c0ac3ac7ed511acc04f67bd1d5. I have pushed a potential fix for this issue now, so the dev version should work.

A quick yes or no if it works or not would be great.

Geethebluesky commented 2 years ago

Hi, just had time to try this again and it works. Pretty enderman eyes! Thanks. :)