AuriRex / GTFO_TheArchive

GTFO Quality of Life mod for almost* any version of the game
MIT License
30 stars 10 forks source link

Bot Customization Bug? #63

Closed Stewerc closed 11 months ago

Stewerc commented 1 year ago

Hello Auri:

Regarding the latest v.0.6.0 release of The Archive, the "Bot Customization", at least for me, has presented issues. Attempts at customizing the apparel of bots will be undone after the game is closed. Once relaunched, bot apparel will be the standard default ones once again. This applies to the experimental BepInEx version, I am unaware if it exists with melonloader as I do not use the latter besides for older rundowns. I had: 1. Created a new, clean profile and deleted all data related to GTFO & The Archive to eliminate any potential conflicts and 2. Reinstalled the necessary data fresh. The issues arose once more despite these steps. This issue was not present in the previous v0.5.52 and conflict with anything else is unlikely as I only operate with the use of:

This is certainly not a top priority to fix, however, you may try to recreate this problem yourself to see if you come up with similar results and implement changes, if necessary, to the next release. Thank you for your time and your amazing work on this mod.

Stewerc commented 1 year ago

UPDATE:

It seems that changing the bots' names is necessary in saving the cosmetic changes to the bots. I was unaware of this and am unsure if this was intentionally made in such a way. Changing this back maintains the changes made whilst the name was changed, however, reverting it back to its original naming of "Woods", "Dauda", "Hackett", and/or "Bishop" then making changes will not save those changes if a the game is shut down and relaunched.

AuriRex commented 1 year ago

It seems that changing the bots' names is necessary in saving the cosmetic changes to the bots.

I might have forgotten to change some things when I implemented changes to how settings are saved, it is indeed not intended for the things to not save haha

This happens because (currently) changing values through code requires me to mark the settings as "dirty" (aka changed) manually for them to save, so the reason they only save after changing a bots name is because after doing that it does get set as "dirty" due to the UI interaction.

Changing names to the default ones shouldn't change anything?

Will fix soon™️