Aurora-RGB / Aurora

Unified lighting effects across multiple brands and various games. http://www.project-aurora.com/
http://www.project-aurora.com/
MIT License
270 stars 38 forks source link

Memory leak since a few Versions #119

Closed cyablo closed 1 year ago

cyablo commented 1 year ago

Expected Behaviour

Memory consumption being sub 1 GB and Aurora Effects being fast.

Actual Behaviour

Aurora starts to consume more and more RAM (I've seen it use the max of 4 GB of RAM) and the Effects on my Keyboard get slower until it crashes with shown Message;

2023-01-07 09_30_24-

Reproduction steps

Just wait for it to eat memory and crash, already ramping up after a few Minutes:

aurora-memory

aurora-memory2

Frequency

2-3 times a day, at least.

Aurora Version:

v108

Previously an Issue?

Yes, but can't say when it started. It could be a few days before christmas I think.


To help debugging, here are my Log files:

Logs.zip

and my Profile I'm using:

desktop.zip

Aytackydln commented 1 year ago

I couldn't find the main cause but I've optimized Aurora for your profile. With the layers you are using memory leak shouldn't be a problem

cyablo commented 1 year ago

Unfortunately doesn't help. Still running out of memory.

Aytackydln commented 1 year ago

https://github.com/Aurora-RGB/Aurora/releases/tag/v110 Memory profiling with this version now had no memory increase

cyablo commented 1 year ago

Thank you, I will test and report.

Btw: The installer does not contain CMSDK.dll and CUESDK.x64_2017.dll. Had to exctract them from source code zip file to make my CoolerMaster Keybaord work again.

cyablo commented 1 year ago

Sorry:

aurora-memory3

Aytackydln commented 1 year ago

This error doesn't always mean memory leak. This mostly happens when programs try to access incorrect memory address. Can you share me your logs?

cyablo commented 1 year ago

Sure:

Logs.zip

Aytackydln commented 1 year ago

Btw, if you have low RAM you should reduce your Bitmap Accuracy. Currently that setting only affects Ambient Layer quality

image

cyablo commented 1 year ago

I'm using Aurora for years, never had any problems like this before. Must be something that changed in the last weeks. My system has 16 GB of RAM, that shouldn't be a problem here.

Aytackydln commented 1 year ago

I found out that the problem is from Matrix Away effect.

Error happens from creating a line that has less than 1 unit of length. I had made check for this to not happen but seems points (20, 19.9) and (20, 20) also throws this error.

cyablo commented 1 year ago

That's right, I use this one. Anything I can do to help?

Aytackydln commented 1 year ago

No, it's easy to fix. Thanks, just reporting more bugs would help :)

cyablo commented 1 year ago

Sorry to be the game spoiler, but I disabled the Matrix away effect and the memory leak is still present, Aurora currently using 7 GB of RAM:

aurora-memory4

Aytackydln commented 1 year ago

Did the memory usage increase with the latest version or was it already happening?

Also, how long does it take to use this much memory?

cyablo commented 1 year ago

I'm on v110 but happens since a few weeks. Starts at around 200 MB and increases until it runs out of memory and then shows the "Out of Memory" error message.

Don't know how long it takes to fill up the RAM. Came back to my PC and noticed the effects stuttering on my Keyboard.

Aytackydln commented 1 year ago

can you send me your whole %appdata%/aurora folder and tell me which games you are using?

cyablo commented 1 year ago

Sure:

Aurora.zip

I'm not playing any games on this Machine, at least no longer :)

Aytackydln commented 1 year ago

My guess is particle layer. I will investigate it. Btw, when I used your previous profile it had different layers

cyablo commented 1 year ago

Dont know. I just use one desktop profile because, no games. Never switch to something else.

profile

Should look like this:

layers

Aytackydln commented 1 year ago

How is the memory usage on last version?

cyablo commented 1 year ago

Sadly that's RAM usage after about 20 hours with v112:

aurora-memory5

cyablo commented 1 year ago

It's not the layers, I think. Made a new profile with just a glitch layer and it also ramps up the memory usage:

aurora-memory6

Maybe it's the CoolerMaster or StelelSeries SDK?

Aytackydln commented 1 year ago

Steelseries sdk might be it. Coolermaster is used by many other people I know and don't have problems

cyablo commented 1 year ago

Steelseries integaration is using Steelseries GG SDK and not RGB.NET, right?

Aytackydln commented 1 year ago

It uses gamesense sdk, not rgb.net

cyablo commented 1 year ago

Didn't know it has a fancy name :) I could try dowgrading SteelSeries GG Software to see if that changes something.

Aytackydln commented 1 year ago

Also, I will add rgb.net implementation next build. Maybe that is better

Aytackydln commented 1 year ago

added rgb.net implementation: https://github.com/Aurora-RGB/Aurora/releases/tag/v116

cyablo commented 1 year ago

Doesn't look like that solved the Issue. RAM usage is still gooing up up up ... :(

aurora-memory7

Aytackydln commented 1 year ago

How long was aurora open with this screenshot? If you're using Ambilight Layer up to 1.5GB usage is okay

cyablo commented 1 year ago

Under 5 MInutes. Not using Ambilight Layer. Memory usage starts at about 250 MB and increases until Aurora freezes/crashes.

cyablo commented 1 year ago

10 Gigs of RAM, yay!

aurora-memory8

It's not the layer, new Profile with onyl one Glitch Layer also has the same beavior. It's not the SteelSeries Integration.

What is causing this and why I'm the only one experiencing it?

Aytackydln commented 1 year ago

there are still some things you can close. %appdata%/Aurora/Config.json EnableAudioCapture, EnableMediaInfo, EnableInputCapture Not too likely they are problems but you can try.

Otherwise I don't think I can find what's the cause without profiling your memory. I can also suggest Artemis-RGB if you don't want to use Aurora anymore

cyablo commented 1 year ago

Disabling the said Optiosn didn't help, as expected.

To be honest, I was very pleased with Aurora since I got my MasterKeys in 2019. It get's the job done and the effects look nice and it has a lot of them to layer up.

I tried Artemis, but the Wiki on Effects is missing and it seems to be way more complex if not impossible to achieve the same effect layers I'm used to from Aurora.

Aytackydln commented 1 year ago

I've fixed a memory leak last patch. Can you check again? https://github.com/Aurora-RGB/Aurora/releases/tag/v129

cyablo commented 1 year ago

Will test and report!

cyablo commented 1 year ago

Seems to be fixed indeed.