Aurora-RGB / Aurora

Unified lighting effects across multiple brands and various games. http://www.project-aurora.com/
http://www.project-aurora.com/
MIT License
266 stars 36 forks source link

Aurora v229 crashes with Logitech GHUB running #205

Closed Froasl closed 7 months ago

Froasl commented 7 months ago

Log when launching fine: 2024-03-31 09.43.06.log Log when crashing: 2024-03-31 09.53.29.log Device log, generated rarely, from the same launch as the log when crashing: Devices-2024-03-31 11.53.47.log (Operating system in logs is incorrect, I'm actually using Windows 11 Pro)

Expected Behaviour

Aurora should launch.

Actual Behaviour

Aurora crashes effectively immediatly on launch, within a few seconds. When it does, it will open multiple error windows. Most of the time, it will keep opening these windows, about one per second, although rarely it will stop after 2 windows. As far as I can tell, there are only 2 different error messages, which can both occur on the same crash. image image

As long as the error messages are not clicked, Aurora will keep updating the keyboard, but with a significant delay and very low refresh rate. When they are closed, either through clicking OK or through the X in the title bar, keyboard lighting will freeze and Aurora will close soon after. When it does not crash, Aurora appears to work perfectly.

Reproduction steps

Have Logitech GHUB running at the same time as Aurora. It does not matter which is started first.

Frequency

Problem occurs most of the time, but not always. Aurora will consistently launch or crash unless GHUB is restarted.

Version:

Aurora v229, started immediately after updating through the automatic updater. GHUB version 2024.2.534136, not updated recently. Windows 11 Pro, version 10.02631 Build 22631, updated before updating Aurora, although before updating Aurora launched without issues once.

Previously an Issue?

No. Aurora did sometimes fail to initialize Logitech RGB.NET, usually when waking the PC from sleep, which would necessitate a restart of GHUB, but this would never crash Aurora.

Aytackydln commented 7 months ago

I made a new pre-release with the fix

Froasl commented 7 months ago

I updated to v230, it is still crashing. It seems like now there is only an InvalidOperationException Log: 2024-03-31 15.16.18.log

Aytackydln commented 7 months ago

Published another release

Also, thank you for testing the beta version

Froasl commented 7 months ago

It seems the original issue has been fixed, but now it crashes most times, but not always, with

System.Reflection.TargetParameterCountException: Parameter count mismatch.
   at System.Reflection.MethodBaseInvoker.ThrowTargetParameterCountException()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Delegate.DynamicInvokeImpl(Object[] args)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

It also does this without GHUB running. No crash: 2024-04-01 06.34.25.log Crash:2024-04-01 06.34.07.log

To be honest, I didn't intentionally beta test, I only enabled pre-release downloads for one patch, and never turned it off. But I will keep it turned on, it is the least I could do for such a great piece of software.

Aytackydln commented 7 months ago

Was there any errors while updating?

Also can you try reinstalling Aurora? This looks like some files are not updated to me

Froasl commented 7 months ago

No errors while updating, except the one when Aurora launched after the update, and reinstalling didn't fix it. I also tried deleting the %appdata%\Roaming\Aurora folder, which also did not affect the crash. I did compare the files before and after reinstalling, but it doesn't seem like any files were missing or different in the old install

Only in Aurora_old/Aurora: Aurora.dll.config
Only in Aurora_old/Aurora: Aurora.sys
Only in Aurora_old/Aurora/AuroraDeviceManager: Wooting.NET.dll
Only in Aurora_old/Aurora/AuroraDeviceManager: mscordaccore_amd64_amd64_8.0.123.58001.dll
Only in Aurora_old/Aurora/AuroraDeviceManager: mscordaccore_amd64_amd64_8.0.224.6711.dll
Only in Aurora_old/Aurora: AuroraRgb.sys
Only in Aurora_new/Aurora: unins000.dat
Only in Aurora_new/Aurora: unins000.exe
Only in Aurora_old/Aurora: unins001.dat
Only in Aurora_old/Aurora: unins001.exe

Another thing I noticed and might mention, when crashing AuroraDeviceManager.exe will keep running in the background and, according to GHUB, is still actively controlling my device lights, although it does stop updating things like CPU usage or shortcuts assists.

Aytackydln commented 7 months ago

Sorry that log doesn't help me much. I've improved exception logs with v232. Hopefully it can tell me what is actually causing it

Froasl commented 7 months ago

Crash: 2024-04-02 04.37.23.log No crash: 2024-04-02 04.45.14.log

The error in line 17 is caused by AuroraDeviceManager still running in the background with that logfile open. When I manually kill it before launching Aurora, that error goes away, but it still crashes.

Aytackydln commented 7 months ago

can you test v233? https://github.com/Aurora-RGB/Aurora/releases

Froasl commented 7 months ago

I missed v233 so auto-updated to v234 directly, and it still crashes. Log doesn't seem different, but I might as well include it: 2024-04-03 07.15.01.log BTW, I did join the discord server, if you'd like to try something where 1 or 2 replies per day isn't quite enough, feel free to message me

Aytackydln commented 7 months ago

I figured out what can cause this error, but I don't see it anywhere in the code. How often and when does it happen?

Froasl commented 7 months ago

It will happen about 80% of normal Aurora launches, the error window will appear at the same time as the main Aurora window. I could not find any pattern when it happens. After some testing, it seems like it only crashes when the GUI opens on launch. I've launched Aurora with the -silent option and it has only crashed when I spam-clicked the tray icon to open the main window. If I wait a bit after launching Aurora, I can open the main window just fine, no crashes yet.

Aytackydln commented 7 months ago

Thanks, that description helped.

Please test v235 and I will make it a full release if you don't have any problems

Froasl commented 7 months ago

So far it is working fine. Thank you for your work.