search

AuroraLS3 / Genie

Genie Bukkit Plugin: https://www.spigotmc.org/resources/genie.43260/
GNU General Public License v3.0
0 stars 1 forks source link

Bugfixes #10

Closed Sharpjaws closed 7 years ago

Sharpjaws commented 7 years ago

Closes #8 and closes #6

non-hostile mobs types are now added to a enum that will be used to compare the Entities. Since it compares them by name it prevents NoSuchField errors from happening between old and new minecraft versions. Ofcourse the polar bear entity is not available in 1.8 resulting in that error. My method just gets the name and compares them to the enums which might be a better solution as you can easily add more mobs in the future to the enum if needed.

Also fixed a bug where the lamp item could not be spawned due to method changes between spigot versions affecting 1.8(Needs confirmation) - 1.8.8(Tested) including the setunbreakable() function being changed slightly.

Sharpjaws commented 7 years ago

I see, no problem I'll change that right away.

Sharpjaws commented 7 years ago

Alright so for confirmation do you want that non-hostile mobs are able to drops the lamp but not the ones you specified in the prevented mobs list? Or do you want to prevent the non-hostile mobs aswell?

AuroraLS3 commented 7 years ago

So that the non-hostile mobs don't drop LAMPS, & hostile mobs drop. The prevented entities in that method are not mobs and deathlistener can't give those as entities. So a list of non hostile mob enum names as strings for that EnumUtility method similar to the linked method.

Sharpjaws commented 7 years ago

Got it, Adjusted. Should be done by now unless there are more changes needed