AuroraLS3 / Genie

Genie Bukkit Plugin: https://www.spigotmc.org/resources/genie.43260/
GNU General Public License v3.0
0 stars 1 forks source link

Wishes not working on 1.16.5 #17

Closed s1h4d0w closed 3 years ago

s1h4d0w commented 3 years ago

Just found out this plugin was updated for 1.16.5, amazing, my players loved this plugin when we were on 1.12.

However, wishes do not seem to work for players. The plugin activates fine and I can drop people genie lamps, but when they wish for an item nothing happens, neither do they see any messages from the plugin. Checking the wishlog of a player also shows 0 wishes.

Running Genie 1.3.0 on latest Paper 1.16.5

Error log shows this, but I created the Wishlog.txt file myself after I used the wishlog command for the first time. Still no wishes being logged there.

java.nio.file.NoSuchFileException: plugins/Genie/Wishlog.txt
   sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
   sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
   sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
   sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:214)
   java.nio.file.Files.newByteChannel(Files.java:361)
   java.nio.file.Files.newByteChannel(Files.java:407)
   java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:384)
   java.nio.file.Files.newInputStream(Files.java:152)
   java.nio.file.Files.newBufferedReader(Files.java:2784)
   java.nio.file.Files.lines(Files.java:3744)
   java.nio.file.Files.lines(Files.java:3785)
   com.djrapitops.genie.file.WishLog.getWishesBy(WishLog.java:50)
   com.djrapitops.genie.command.commands.WishLogCommand$1.run(WishLogCommand.java:51)
   com.djrapitops.plugin.genie.task.RunnableFactory$1.run(RunnableFactory.java:39)
   org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:99)
   org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54)
   com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22)
   java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   java.lang.Thread.run(Thread.java:748)
Error was logged: Feb 19, 00:56:22
AuroraLS3 commented 3 years ago

I'll try to get this fixed asap

AuroraLS3 commented 3 years ago

It looks like the way item meta is represented has changed and as result lamp item detection is broken