search

Auroras-live / issues

Issue tracker for Auroras.live (including mobile, web and watch apps)
1 stars 0 forks source link

The brightness is reset on iOS #16

Closed Grayda closed 5 years ago

Grayda commented 7 years ago

Night mode inadvertently resets the screen brightness on iOS. This is confirmed on my iPhone 4, but doesn't seem to happen on my Nexus 6P (though it should, which is odd)

To replicate:

  1. Ensure the app is completely closed.
  2. Set your brightness to 0% in the Settings app or the swipe-up settings menu
  3. Open the app. Brightness is set to 100%

The offending code looks like this:

if (nightmode == true) {
  brightness.setBrightness(0)
} else {
  brightness.setBrightness(100)
}

Obviously if nightmode is false (e.g. NOT enabled), then we shouldn't touch the brightness. But we accidentally do, so definitely a bug :smile:

This has been fixed and will be released in the next version, which should be soon, as I have some map updates I want to roll out.

Grayda commented 7 years ago

Another bug to add to this: Night mode doesn't seem to "stick" on iOS:

  1. Open the app
  2. Set night mode.
  3. Exit the app completely (swipe to exit and all)
  4. Launch it again.

You'd expect night mode to be enabled and the brightness to hit 0 again, but it doesn't. It shoots back up to 100%. On Android it behaves as expected.

Will look into this too.

Grayda commented 7 years ago

Accidentally closed via commit. It's been fixed, but not yet released. Reopening.

Grayda commented 5 years ago

Closing, as I believe this has been fixed in Capacitor.