search

Aurorastation / Aurora.3

The code for Aurorastation's new base, forked from Baystation12.
http://aurorastation.org/
GNU Affero General Public License v3.0
139 stars 506 forks source link

Restricts Wildlands flagpatches from Command #19506

Closed dessysalta closed 1 week ago

dessysalta commented 2 weeks ago

Heads of Staff can't wear Wildlands flagpatches. Matt said there are probably inoffensive ones out of the four you can pick, but this is a band-aid change because I don't want to learn how to restrict certain items out of a selection in the loadout to command.

I figured that liaisons and consuls can't wear them either, on account of consuls that would wear them probably being Solarian (and thus not allowed to be on ship in the first place) and liaisons being inherently corporate/generally anti-Sol.

Catrly commented 2 weeks ago

Would it not be better to just add a comment saying that people should be careful picking these? To other things too, maybe. This seems not the best way of doing it for the reasons mentioned in your PR.

dessysalta commented 2 weeks ago

Would it not be better to just add a comment saying that people should be careful picking these? To other things too, maybe. This seems not the best way of doing it for the reasons mentioned in your PR.

Maybe? IDK, I'll wait for maintainer/dev advice. That feels like it would very quickly progress to "write a blurb for a million things because there are specific use cases for some of the selections," which off the top of my head only the sec eyewear/uniforms mention.

E: Also, the page of the Wildlands already says "your character should have a good reason to be from here", which should generally also translate as "your character should have a good reason to be openly affiliated with these people".

dessysalta commented 1 week ago

!review

DreamySkrell commented 1 week ago

I really don't think this is necessary. This fixes a very, very niche issue.

Especially since as said in the PR desc, this is a bandaid change.

We don't restrict flags or whatever other things from heads of staff, that they should not be taking. Stuff like Solarian Colonial Mandate of Tau Ceti flag, for example.

I don't want to the loadout bloated with restrictions like this.

dessysalta commented 1 week ago

We don't restrict flags or whatever other things from heads of staff, that they should not be taking. Stuff like Solarian Colonial Mandate of Tau Ceti flag, for example.

Then you run into issues like normal characters having it and using it and promoting that character to a leadership position (see: me) who don't know any better and then have a run-in with staff. Fair enough though, I'll close it and then anyone else can reopen it if they think it's a big enough issue.