Aurorastation / Aurora.3

The code for Aurorastation's new base, forked from Baystation12.
http://aurorastation.org/
GNU Affero General Public License v3.0
146 stars 514 forks source link

AI misc QOL updates. #19510

Closed Magisterium2022 closed 3 months ago

Magisterium2022 commented 3 months ago

Updated the AI's hardware from basic to higher-grade versions, as they can't typically be upgraded during a round. Added potentially useful software which was not previously available through their downloader. Added drone language for communications and control. Disabled the block on electrifying doors, as law conflicts may permit it in some cases.

Magisterium2022 commented 3 months ago

!review

FluffyGhoster commented 3 months ago

This needs a changelog as it'd be a player-facing change

Magisterium2022 commented 3 months ago

The list of changes is above, would you prefer any additional information be added or reformatted? A list of all lines of code that have been changed would also be possible if you'd prefer, given the small size of this PR.

FluffyGhoster commented 3 months ago

The list of changes is above, would you prefer any additional information be added or reformatted? A list of all lines of code that have been changed would also be possible if you'd prefer, given the small size of this PR.

Per https://github.com/Aurorastation/Aurora.3/blob/master/.github/CONTRIBUTING.md

"All pull requests which contain player-visible changes are required to have a changelog."

Arrow768 commented 3 months ago

Regarding: "Disabled the block on electrifying doors, as law conflicts may permit it in some cases."

A law conflict would never permit you to electrify a door. The result of a law conflict is inaction (as mentioned on the wiki)

Magisterium2022 commented 3 months ago

Regarding: "Disabled the block on electrifying doors, as law conflicts may permit it in some cases."

A law conflict would never permit you to electrify a door. The result of a law conflict is inaction (as mentioned on the wiki)

Apologies, yes, my mistake. Some lawsets would permit that, not law conflicts. Currently it just checks to see if you're malf, so if someone were to wipe an AI's laws and replace it with a generic "Obey all instructions from X" lawset, they still wouldn't be able to do so.

Magisterium2022 commented 3 months ago

And a changelog has been added.

Magisterium2022 commented 3 months ago

Electrification code has been returned to normal, and mention of electrification removed from changelog.