search

Aurorastation / Aurora.3

The code for Aurorastation's new base, forked from Baystation12.
http://aurorastation.org/
GNU Affero General Public License v3.0
148 stars 518 forks source link

Baseline IPC Screens do not use the delay feature. #8489

Open niennab opened 4 years ago

niennab commented 4 years ago

I do not know if this is intended or can be addressed but I have noticed in making Baseline screens and seeing some ported in from other servers, the Aurora doesn't seem to acknowledge the delay portion of the animation. Meaning that animations default to a 1 delay and are often too fast if they were build with the delay in mind.

As an example, ipc_eye, a screen that I made with the delay in mind, has this very issue.

I am willing to fix each screen that has this issue but if we can have the system acknowledge the delays, I believe that is better.

Below is an example of how the frame delay it utilized.

delay

Chada-1 commented 4 years ago

As said on Discord I think the thingo causing this is that the overlays are being applied differently than they are for 'borgs which don't have this problem. I couldn't find where they were being applied in the code to verify but one thing you could try is to go ingame with the screen that you want and then use the 'Change Screen' verb IPCs get to swap to another, then back, and see if the delay is still broken. If it works properly after that, it's how the initial overlay is applied I'd bet.

If that's the problem it could be as simple as making it apply the overlay after spawn (Instead of spawning you with it possibly?) rather than whatever it does currently, if it doesn't already do that.

EDIT: And if they don't use overlays, that could be the problem too, it not being an overlay could like, make it play by different rules, in that case I'd have actually no clue what to do, but converting them to overlays would probably fix this problem too

EDIT 2: After looking into this further, this is all stonewalled by the human mob code being the same between IPCs and every other mob, which makes facial hair seem to be locked to 1 delay. You'll have to just convert animations to 1 delay unless someone else knows how to fix this thing or wants to convert it to something that isn't shared by all human mobs.

niennab commented 4 years ago

I am willing to fix all of the screens to be a 1 delay but since we've taken a number of these screens from other servers, I wagered it might be worth looking into perhaps how it's handled there. Naturally, the better fix is to somehow incorporate the delay but I understand if it can't be done.

Chada-1 commented 4 years ago

I could look at another servers codebase and try to figure out where the difference is but I'm not positive if I'll find anything, since I plan to change IPCs soon to have glow in the dark eyes I'll do it at the same time