AuroreAA / ICSClust

What the Package Does in One 'Title Case' Line
GNU General Public License v3.0
0 stars 0 forks source link

naming of MCD wrappers #24

Closed klauschN closed 1 year ago

klauschN commented 1 year ago

Currently ICS_mcd gives the raw MCD and ICS_rmcd the reweighted MCD. I am not sure about the names. As people usually use the function mcd to get the reweighted mcd and they have to to something extra to get the raw mcd. Therefore I am wondering if it would be more meaningful to change the names and rmcd would be then the raw Mcd.

AuroreAA commented 1 year ago

Do you prefer:

aalfons commented 1 year ago

I don't have a strong preference on the order, both are fine for me. I do like rwt better than rwgt, then both wrappers use the same number of letters.

klauschN commented 1 year ago

I have also no strong preference here but would probably lean towards the first option. And I also would drop the g in rwgt.

AuroreAA commented 1 year ago

In fact I would prefer ICS_mcd_raw and ICS_mcd_rwt. Indeed, my first thought would be, I want to compute mcd so ICS_mcd and then I am thinking about what I want to use raw or reweighted.

Is it fine with you @klauschN ?

klauschN commented 1 year ago

Yes, also fine by me