Auroriax / PuzzleScriptPlus

Puzzlescript Plus: Open Source HTML5 Puzzle Game Engine (with lots of extra functionality)
https://auroriax.github.io/PuzzleScript/
34 stars 4 forks source link

URL creation should not be stopped because of warnings [CLOSED ISSUE ALREADY EXISTS.] #114

Closed Monakrom closed 1 year ago

Monakrom commented 1 year ago

Check ([ ] -> [x]) all that apply, then describe the issue below:

The URL compiler says "Cannot link directly to playable game, because there are compiler errors." even when there are only warnings and no errors. For example, when trying to create a link to a playable build where both tweening and late rules exist, you will be stopped with the aforementioned message. This also means you cannot use brackets as symbols in level ascii, or have even slight inconsistencies in code, such as irregularly sized levels and the like.

More likely than not, the developer of the game is very aware of warnings in the console, and has decided that they are unimportant, at least for the time being.

With all of that in mind I feel like this is unnecessarily rigid, and links to playable games should be allowed even when there are warnings visible in the console, which is how it is in regular Puzzlescript.

Monakrom commented 1 year ago

Missed a closed issue on it. Still think it’s a problem though.

david-pfx commented 1 year ago

This is not the cause. There is a long-standing bug in PS+ whereby warnings get counted as errors. I'll raise an issue.

Monakrom commented 1 year ago

This is not the cause. There is a long-standing bug in PS+ whereby warnings get counted as errors. I'll raise an issue.

Ahh ok. Didn’t know that. That certainly explains it.

david-pfx commented 1 year ago

Yes, I've now checked it and it does seem that #115 is the cause of this problem.

I already fixed it in PS Next and forgot to raise the issue in PS+.