search

Auroriax / PuzzleScriptPlus

Puzzlescript Plus: Open Source HTML5 Puzzle Game Engine (with lots of extra functionality)
https://auroriax.github.io/PuzzleScript/
35 stars 5 forks source link

Some warnings get counted as errors #115

Open david-pfx opened 1 year ago

david-pfx commented 1 year ago

At parser.js line 64, if logWarning is called without a line number, it will call logWarningNoLine, which defaults to increaseErrorCount=true. The result (and the fix) are obvious. Warnings should not increase the error count.

The fix is line 76: function logWarningNoLine(str,urgent, increaseErrorCount = true) { should be function logWarningNoLine(str,urgent, increaseErrorCount = false) {

david-pfx commented 1 year ago

BTW it really isn't worth a PR. Hope that's enough.

david-pfx commented 10 months ago

This bug is fixed in PS Next.