search

Auroriax / PuzzleScriptPlus

Puzzlescript Plus: Open Source HTML5 Puzzle Game Engine (with lots of extra functionality)
https://auroriax.github.io/PuzzleScript/
35 stars 5 forks source link

Maximum Limit of 1.4 MB #126

Open just-kirb opened 3 months ago

just-kirb commented 3 months ago

Describe the bug A game cannot store over 1.4MB of data in a link as it starts deleting the ending lines of code.

Reproduction Steps

  1. Make a game with lots of rules to check and exceed 1.4MB of data.
  2. Share the game with the link.
  3. Open it.

What did you expect would happen? The data being intact after sharing the link to others.

OS & Browser version, desktop/mobile Edition: Windows 10 Home Single Language OS Version: 22H2 Firefox Version 129.0.2 (64-bit)

Screenshots, example projects, other relevant issues, etc. image information before sharing the link image information removed when sharing the link

david-pfx commented 3 months ago

Data? Do you means lines of script code? That would be maybe 50 KLOC. Do games that big actually work?

just-kirb commented 3 months ago

I mean the games up until that point work fine when programming, however the issue probably comes from GitHub's limit on storing data in links (i verified saving the game doesn't cause an override, but sharing it though a link does), here is a video demonstrating the problem more clearly:

https://github.com/user-attachments/assets/734fde5e-80c5-4b31-97b1-b650ff957b8c

just-kirb commented 2 months ago

UPDATE: i feel like the puzzlescript machine for github gists only scraped a truncated portion of the script, and not the actual full version, causing a cutoff, but the full file is still intact

david-pfx commented 2 months ago

I’m happy to look at it, but I do need a repro. The Gist maybe.

Regards

David M Bennett FACS

Polyomino Games – Programming Languages and Players for Games and Puzzles -- http://www.polyomino.com http://www.polyomino.com/

From: just-kirb @.> Sent: Wednesday, 4 September 2024 10:01 PM To: Auroriax/PuzzleScriptPlus @.> Cc: david-pfx @.>; Comment @.> Subject: Re: [Auroriax/PuzzleScriptPlus] Maximum Limit of 1.4 MB (Issue #126)

UPDATE: i feel like the puzzlescript machine for github gists only scraped a truncated portion of the script, and not the actual full version, causing a cutoff, but the full file is still intact

— Reply to this email directly, view it on GitHub https://github.com/Auroriax/PuzzleScriptPlus/issues/126#issuecomment-2328778048 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBMEXJIPMS6MT4NY2VE6MTZU3Y7TAVCNFSM6AAAAABNPTUTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYG43TQMBUHA . You are receiving this because you commented.Message ID: @.***>

just-kirb commented 2 months ago

https://gist.github.com/just-kirb/dd9d7807216b610c716a5ed4e7c5340c

On Wed, Sep 4, 2024 at 8:20 PM david-pfx @.***> wrote:

I’m happy to look at it, but I do need a repro. The Gist maybe.

Regards

David M Bennett FACS

Polyomino Games – Programming Languages and Players for Games and Puzzles -- http://www.polyomino.com http://www.polyomino.com/

From: just-kirb @.> Sent: Wednesday, 4 September 2024 10:01 PM To: Auroriax/PuzzleScriptPlus @.> Cc: david-pfx @.>; Comment @.> Subject: Re: [Auroriax/PuzzleScriptPlus] Maximum Limit of 1.4 MB (Issue

126)

UPDATE: i feel like the puzzlescript machine for github gists only scraped a truncated portion of the script, and not the actual full version, causing a cutoff, but the full file is still intact

— Reply to this email directly, view it on GitHub < https://github.com/Auroriax/PuzzleScriptPlus/issues/126#issuecomment-2328778048> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADBMEXJIPMS6MT4NY2VE6MTZU3Y7TAVCNFSM6AAAAABNPTUTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYG43TQMBUHA> . You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Auroriax/PuzzleScriptPlus/issues/126#issuecomment-2328830079, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKAS3CQNV3GAJAXKLOV7KRDZU33HBAVCNFSM6AAAAABNPTUTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYHAZTAMBXHE . You are receiving this because you authored the thread.Message ID: @.***>

david-pfx commented 2 months ago

Yes, it's real. It seems to affect every fork. It truncates in line 22977.

Is it a Github problem/limit? In any case, I don't this is fixable.

just-kirb commented 2 months ago

wait the github program that runs puzzlescript plus doesn't have a way to scrape gists fully if it's truncated?

On Fri, Sep 6, 2024 at 9:37 PM david-pfx @.***> wrote:

Yes, it's real. It seems to affect every fork. It truncates in line 22977.

Is it a Github problem/limit? In any case, I don't this is fixable.

— Reply to this email directly, view it on GitHub https://github.com/Auroriax/PuzzleScriptPlus/issues/126#issuecomment-2334079104, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKAS3CVPF35BGEZ2KFX27H3ZVGV2TAVCNFSM6AAAAABNPTUTMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGA3TSMJQGQ . You are receiving this because you authored the thread.Message ID: @.***>