search

AusClimateService / indices

Code for calculating climate indices
5 stars 6 forks source link

DTR/ETR/vDTR results have degK to degC temperature conversion applied #12

Closed ngben closed 1 year ago

ngben commented 1 year ago

I'm not sure if this is an icclim issue or a run_icclim.py issue but I've found that DTR/vDTR/EDTR variables have 273.15 subtracted from the results. It appears that the conversion from degK to degC is being applied after the index calculation.

image

DamienIrving commented 1 year ago

Looks like it's a problem with icclim - I've submitted an issue to the developers: https://github.com/cerfacs-globc/icclim/issues/255

Do you want me to implement a temporary fix in run_icclim.py until the problem is resolved in the icclim package itself?

ngben commented 1 year ago

Thanks Damien, it's not urgent so we can wait until icclim fixes it.

ngben commented 1 year ago

I think this has been fixed in icclim 6.3.0

DamienIrving commented 1 year ago

Yep, they fixed it last week (https://github.com/cerfacs-globc/icclim/pull/258) so it should be in the next release.

DamienIrving commented 1 year ago

6.3.0 is out now :smile: