PR holds a range of bugfixes that probably could have been done better split up, but hey, here is… fixes:
a number of content links broken in prod due to missing site.baseurl
missing site.baseurl in the head include for the link rel="icon"
attempts a fix for the browserconfig.xml icon config (hoping that {{ site.baseurl }} is processed here, as it would be in other XML files (eg feed or sitemaps)…
further SASS patching for the “back to contents” link within each section, depending on what preceded it
Additional information
Egs of a page where the back to contents skip links were borked:
Also, I noticed that the Layout section is missing the Responsive breakpoint stuff entirely — the -top.md for it is empty, and the guidance was still using the old HTML markup for <details> — I checked the IA spreadsheet and it looks like it should be there… maybe an oversight, or something intentionally left out for now by Jools, but defs. something we should check up when he gets back.
Definition of Done
[ ] Content/documentation reviewed by Jools or someone in the #content-design team
[ ] UX reviewed by Gary or someone the Design team
Description
PR holds a range of bugfixes that probably could have been done better split up, but hey, here is… fixes:
site.baseurlsite.baseurlin the head include for thelink rel="icon"browserconfig.xmlicon config (hoping that{{ site.baseurl }}is processed here, as it would be in other XML files (eg feed or sitemaps)…Additional information
Egs of a page where the back to contents skip links were borked:
Also, I noticed that the Layout section is missing the Responsive breakpoint stuff entirely — the
-top.mdfor it is empty, and the guidance was still using the old HTML markup for<details>— I checked the IA spreadsheet and it looks like it should be there… maybe an oversight, or something intentionally left out for now by Jools, but defs. something we should check up when he gets back.Definition of Done