AusDTO / dto-design-guide

- DEPRICATED - Please see:
https://designsystem.gov.au/
MIT License
10 stars 6 forks source link

Feature/callout documentation #124

Closed klepas closed 7 years ago

klepas commented 7 years ago

Description

Adds basic (missing) documentation for the existing (and three new) callouts under the Patterns section.

When merged this should fix for https://github.com/AusDTO/dto-design-guide/issues/119

That issue holds the bulk of the bg info.

Happy to leave this PR open for Jools to work on, or we could merge and ensure Jools sees it when he comes back — undoubtedly there’s content debt here that we will want to fix…

Additional information

Screenshot:

screen shot 2017-01-12 at 11 59 48 am

Definition of Done

AndrewArch commented 7 years ago

maybe we could consider a brighter green for 'success' (eg #008000) in a future release?

klepas commented 7 years ago

maybe we could consider a brighter green for 'success' (eg #008000) in a future release?

@AndrewArch yea, happy to when we revisit colours in 2.x. At the moment this colour ($success-green) is setup and shared in a bunch of other places, namely forms.

joolswood commented 7 years ago

Hey @dominikwilkowski and @klepas I don't think this is in the right place. I think what we've got are code and examples for a component called "callouts".

When we provide guidance and examples of how these components are used as part of a service to help the user then that content should go in Patterns. But I don't think we'll get to this until 2.0.

So I'd like to move this content to the Components collection and do some work on the lead-in and examples.

klepas commented 7 years ago

So I'd like to move this content to the Components collection and do some work on the lead-in and examples.

@joolswood I however want to close #119 now, and add a new issue assigned to you if you want to move this within the 1.x documentation site.