AusDTO / gov-au-beta

User facing frontend to the GOV.AU content site.
MIT License
10 stars 6 forks source link

feature: Basic image upload to S3 #494

Closed maxious closed 8 years ago

maxious commented 8 years ago

Addresses SITES-678

This implementation uploads files to S3 with the SHA1 in the filename suffixed with a "style" - original, medium and thumbnail. That is, thumbnails and downscaled images are automatically generated during the file upload. However, width/height are not stored in the database.

The Asset.asset_file object has a .url function. For testing this is generating raw S3 URLs but can be customised as "s3_host_alias"

An asset can be uploaded through editorial. There is no metadata entered manually and the URL is displayed in a flash message after upload.

ltankey commented 8 years ago

We should probably update the changelog also.

ltankey commented 8 years ago

LGTM

tessereth commented 8 years ago

There are no controller tests for this PR

tessereth commented 8 years ago

Other than the breadcrumb for the asset index page, this LGTM.