search

AusDTO / gov-au-ui-kit

MOVED TO https://github.com/govau/uikit/
https://github.com/govau/uikit/
MIT License
19 stars 12 forks source link

Bug - Global nav doesn't open completely (iOS9) #351

Open TrebBrennan opened 8 years ago

TrebBrennan commented 8 years ago

What browser and device I was using

iPhone4:iOS4-safari on Browserstack

What I expected to see

Opening the global nav reveals all content.

What I saw

Some content is cut off, or hidden:

screen shot 2016-09-06 at 3 13 10 pm
klepas commented 8 years ago

Tracked under DESIGN-428.

petronbot commented 8 years ago

Further testing shows that this issue is specific to iOS4. iOS 5 & 6 show the nav fallback (open-by-default) and the hide/show behaviour kicks in at iOS 7.

Local nav (fallback) on iOS 5:

image

ashnewport commented 8 years ago

I think the issue you are seeing @TrebBrennan is caused by the padding being in the wrong spot. From responsive-nav:

Calculated Max-height doesn't account for top/bottom padding on .nav-collapse (this is on purpose). If you need to add padding inside the nav, you can apply it to any other element, for example the <ul> inside .nav-collapse.

I just added into our alpha locally .global-nav ul { padding-bottom: 0.8em } and that seems to have worked. I got the padding value from the existing style declaration .global-nav { padding: 0.4em 0 0.8em; }