Closed klepas closed 7 years ago
We need to discuss what the deprecation process will be like for the existing global-nav feature (since we may have a namespace clash).
Quick reference implementation (NOT fully complete as per the mockup):
[private repo]
We need to have a quick chat re. the deprecation of the existing, semi-complete .global-nav
, and how we’re going to pull the above noted draft implementation over into the ui-kit, and then when we’ll do the release.
As per chats in Slack, we'll leave Global nav in UI Kit for now as it is, since it has a purpose that's distinct from the new styles.
The new nav style can be .site-nav
, meaning we'll have 3 levels of navigation to choose from:
Remaining tasks:
Edit from Petch: Pls see Issue description above for To do list
@gazhands Hey, I just realised the design guide site-nav header is missing the grey bar that our nav item :hover
styling sits on — compare:
@petronbot We also have this mobile design from Gaz:
I think the idea here is that it represents the state of a user having opened on of the top-level site nav items to see its children; access to child items is only available in mobile/tablet view.
Next up I’ll show some screenshots of the current DTA website draft implementation.
@gazhands is there a reason why the search input design differs from the UI-Kit text input fields?
@gazhands Where do 2nd level nav items go on desktop?
@klepas Confirming that the 'grey bar' should be there on desktop
To swarm on today with design and dev
@gazhands The updated mocks are looking good - they solve all the blocks we'd put down 👍
@gazhands @petronbot General agreement — these look really good.
Two interaction-related thoughts/concerns:
I heard via Petch that we might ignore the whole-of-guides nav (grey bar) for now — if we move the search box in mobile view to its position (above the logo, I know…) I think we could avoid the search functionality becoming a nav item. What do ya’ll reckon? (:
Implement as an include and ideally place the SASS into UI-Kit; if not sure we can keep this as application SASS inside the
dto-design-guide
repo and refactor it upstream into UI-Kit later once we have more assurance on the feature.Blocks:
To do: