Feature/site search - Githubissues

AusDTO / gov-au-ui-kit

MOVED TO https://github.com/govau/uikit/

https://github.com/govau/uikit/

MIT License

19 stars 12 forks source link

Feature/site search #432

Closed TrebBrennan closed 7 years ago

TrebBrennan commented 7 years ago

screen-shot-2016-10-25-at-12 11 03-pm

A plug-n-play site-search component designed to be as modular and responsive as possible.

Values for colours etc are all declared at the top of the partial so it's easy to customise as needed.
Checked in a variety of browsers but ie7 needs some love.
Validated HTML for W3C and WCAG.
Accessibility discussed and approved with SME.

PS... Sorry, not-sorry, for the jQuery :P

klepas commented 7 years ago

Things that I see left here:

possible design changes to make the input field match the existing input design (ez)
rewrite the jquery component in plain JS (Petch? :S)
incorporate into our codebase
final testing

petronbot commented 7 years ago

I've rewritten the JavaScript so that it doesn't depend on JQuery, but still works in IE8+.

I think this needs a bit of content help from @joolswood, some final testing and then we can merge.

klepas commented 7 years ago

@petronbot I also wanna tweak the vars for the input style so that it matches our other text input fields, just for consistency.

klepas commented 7 years ago

@petronbot I reckon you’ll have to get @danwhitmarsh to review your eidts; I can’t. :S

joolswood commented 7 years ago

@petronbot I can take a look at this after AusDTO/dto-design-guide#25

gordcorp commented 7 years ago

FYI have noticed a slight glitch where this is implemented on the dta-website. If you do a search, and then hit the back button, the search query and placeholder text are drawn on top of it.

klepas commented 7 years ago

Found another item to hunt down — this is what happens when JS is disabled:

screen shot 2016-11-07 at 1 50 26 pm

TrebBrennan commented 7 years ago

@klepas just set the variable on this line: https://github.com/AusDTO/gov-au-ui-kit/pull/432/files#diff-964067dbbd2240240a0ac21c855c873cR67

RE: @bjgordon's bug above, the JS needs to also be triggered onload not just input change.

joolswood commented 7 years ago

We don't have any doco on the component yet @hannah-ustwo suggest reopening or creating a new ticket.