AusDTO / gov-au-ui-kit

MOVED TO https://github.com/govau/uikit/
https://github.com/govau/uikit/
MIT License
19 stars 12 forks source link

Extension of callout states and minor refactoring #449

Closed DJMyles closed 7 years ago

DJMyles commented 7 years ago

Note: Since devel changed so much I reforked and started again since my changes were pretty minor. I closed my old pull request and created this one.

Description

The UI kit at the moment includes a base callout class and a warning variant. This branch seeks to include states for success, error and info, updates the warning variant to use the correct $colour-warning variable and adds a small amount of refactoring by pushing some duplicated attributes to the base callout where possible.

Additional information

N/A

Definition of Done

klepas commented 7 years ago

Things I need to do to get this merged:

DJMyles commented 7 years ago

@klepas in regards to the colours, I took the variables I used directly from the warning variables here: http://guides.service.gov.au/design-guide/foundations/colours/index.html

klepas commented 7 years ago

@DJMyles Re. colours: cheers. This reminds me further that we need to extend those out further, and improve the documentation on the functional vars we have (rather than just the mere descriptive colour variables) on the new documentation page…

I’m going to merge this into `develop, and then add on top of it.

There’ll be a separate ticket going into the design guide repo to update the documentation for this feature (actually, callouts got sadly lost in the transition and are missing entirely at the moment) before we do another release.