Fix / enhancement - markup of footer menus in footer-top - Githubissues

AusDTO / gov-au-ui-kit

MOVED TO https://github.com/govau/uikit/

https://github.com/govau/uikit/

MIT License

19 stars 12 forks source link

Fix / enhancement - markup of footer menus in footer-top #453

Closed klepas closed 7 years ago

klepas commented 7 years ago

Description

This is a re-submission of @DJMyles’ footer semantics bugfix.

See the issue with all the details: https://github.com/AusDTO/gov-au-ui-kit/issues/448

Previous PR: https://github.com/AusDTO/gov-au-ui-kit/pull/450

Additional information

This would be a breaking change, requiring templates to be updated — minor.

Definition of Done

[ ] Content/documentation reviewed by Julian or someone in the Content Team
[ ] UX reviewed by Gary or someone the Design team
[ ] Code reviewed by one of the core developers
[ ] Acceptance Testing
- [ ] Cross-browser tested against standard browser matrix
- [ ] Tested on multiple devices (TBD)
- [x] HTML5 validation (CircleCI)
- [x] Accessibility testing & WCAG2 compliance (npm test)
[ ] Stakeholder/PO review
[x] CHANGELOG updated