search

AusDTO / gov-au-ui-kit

MOVED TO https://github.com/govau/uikit/
https://github.com/govau/uikit/
MIT License
19 stars 12 forks source link

Bug: link styles should have color set using "currentColor" #454

Closed elisechant closed 7 years ago

elisechant commented 7 years ago

Link styles should inherit their color from their encapsulated text, set to:

color: currentColor

dominikwilkowski commented 7 years ago

shouldn't link color always be... link color?

elisechant commented 7 years ago

yes, well then define link color. currently body text color, unless i am mistaken

DJMyles commented 7 years ago

I'm showing link colours defined as following:

header[role='banner'] {
  @include link-colours($non-black, $light-aqua, $non-black);
}

body > main {
  @include link-colours($non-black, $light-aqua, $non-black);
}

footer[role='contentinfo'] {
  @include link-colours($non-black, $light-aqua, $non-black);
}

And the mixin syntax:

@mixin link-colours($text-colour, $hover-bg-colour, $hover-text-colour: $text-colour) {
   <stuff here...>
}

Can you provide an example of where the link colour isn't correct or needs changing?

klepas commented 7 years ago

After a chat with @elisechant I’m closing this.

Link styles will be revisited in 2.x.