Aussieforks / australia

Updated fork of the original Australia mod for Minetest v5.7
Other
1 stars 3 forks source link

Clobbered Ore Generation #17

Open Maverick2797 opened 1 year ago

Maverick2797 commented 1 year ago

Australia currently clobbers existing ore generation, leaving mod loading order to determine whether moreores, technic and other ore providing mods actually generate ores.

Also has no reference to default's tin ore, which is essential for some technic recipes.

I suggest flipping the minetest.settings:get_bool("australia.clear_ores", true) in mapgen.lua:9 to default to false, leaving the manual definitions added further below and in individual biome profiles to determine additional ore generations.

Maverick2797 commented 1 year ago

partially addressed by #19

Montandalar commented 1 year ago

At this stage I think it is best for backwards compatibility to preserve the clobbering. However, we must then make it possible to run other mods like technic_worldgen, moreores and others at the same time.

I can't think of a better architecture for that yet though, other than to have support mods in the modpack (#18) that re-register ores, via API or copy and paste if not possible to add API. Otherwise you cause a lot of potential circular dependencies.