Add 1.20.4 support - Githubissues

Aust1n46 / VentureChat

GNU General Public License v3.0

37 stars 46 forks source link

Add 1.20.4 support #103

Closed ItsDoot closed 6 months ago

ItsDoot commented 6 months ago

Happy New Years 🎉

Saw that you mentioned you would be gone until the new year, and I really wanted 1.20.4 support for myself. I've verified it works on 1.20.4, but not that it still works on older versions. Feel free to use this however you want, even as a starting point for your own version of 1.20.4 support 😄

Aust1n46 commented 6 months ago

The change to the modifiers json type from String -> Boolean will probably break older versions. I'll need to add version handling around that and make it ugly sadly...

The chat packet creator is implemented exactly how I would've done it.

Thanks for the leg work!

Nanpure commented 6 months ago

Our server is still using 1.20.2 as we wait for plugins to update. However, we are using ViaVersion to support both Java and Bedrock clients which are on 1.20.4. This patch assumes that the server is on 1.20.4, and still produces a disconnection when the new version packet is received, causing a disconnect.

Is it possible to detect and handle that the new packet version while running an older server version?

Aust1n46 commented 6 months ago

Released 3.7.0

Thanks!