search

Aust1n46 / VentureChat

GNU General Public License v3.0
37 stars 47 forks source link

Adds an event for private messaging #49

Closed ks-hl closed 1 year ago

ks-hl commented 1 year ago

There is currently now way to listen to messages within the API. This adds an event that fires when a player sends a message to another player.

This is similar to https://github.com/Aust1n46/VentureChat/pull/8 but provides the ability to modify the message or cancel it with a custom cancellation message.

Thanks for your time!

Aust1n46 commented 1 year ago

~The styling and formatting is also not inline with the rest of the project. I will create an issue branch for this to be merged into and not directly into master.~

I forgot about #8 from LOOHP. Their PR has pretty much what I'm looking for and it's written against the new 4.0.0 version. Will more than likely go with that once I get around to releasing 4.0.0.

ks-hl commented 1 year ago

~The styling and formatting is also not inline with the rest of the project. I will create an issue branch for this to be merged into and not directly into master.~

I forgot about #8 from LOOHP. Their PR has pretty much what I'm looking for and it's written against the new 4.0.0 version. Will more than likely go with that once I get around to releasing 4.0.0.

[#8] isn't modifiable/cancellable. Like I said, that's the whole point of this PR.

Aust1n46 commented 1 year ago

~The styling and formatting is also not inline with the rest of the project. I will create an issue branch for this to be merged into and not directly into master.~ I forgot about #8 from LOOHP. Their PR has pretty much what I'm looking for and it's written against the new 4.0.0 version. Will more than likely go with that once I get around to releasing 4.0.0.

[#8] isn't modifiable/cancellable. Like I said, that's the whole point of this PR.

It is modifiable, it's just not cancellable. I can suggest cancellable to him and I'm sure he will make the change, or I can just push it myself.