search

Aust1n46 / VentureChat

GNU General Public License v3.0
37 stars 47 forks source link

VentureChat cancelling AsyncPlayerChatEvent #72

Closed david1117dev closed 8 months ago

david1117dev commented 1 year ago

Hello, I have a small problem. 2 month ago, I installed discordsrv with venturechat, it worked but now, it don't send messages to discord.

Plugin VentureChat v3.5.0 cancelled AsyncPlayerChatEvent (Bukkit) (author: david1117 | message: s) [08:03:01 INFO]: [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] Chat message received, canceled: true, channel: Global [08:03:01 INFO]: [DiscordSRV] [MINECRAFT_TO_DISCORD DEBUG] User david1117 sent a message but it was not delivered to Discord because the chat event was canceled

Server version is 1.18.2

Logs https://mclo.gs/ANn9hdv

Aust1n46 commented 1 year ago

VentureChat does cancel the AsyncPlayerChatEvent. I fire my own event that DiscordSRV listens to and hooks into.

I don't know what settings you are using, but DiscordSRV supports VentureChat.

vertanzil commented 1 year ago

This is also the same @Aust1n46 if you run custom code that also interacts with the PlayerChat event, can you fix this or find a workaround?.

joshwenke commented 1 year ago

This is a really big issue for us as well. VentureChat stomps on our other chat plugins, even when their priorities are set to highest. Hoping it can be addressed

joshwenke commented 12 months ago

After changing our plugin priorities below highest, they are now playing nicely with VentureChat. Perhaps this was our issue of not knowing that lower plugin priorities fire first.

Aust1n46 commented 12 months ago

I'm glad you were able to figure it out on your own. I always appreciate that!

For future reference, the event firing order is listed in the documentation: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/event/EventPriority.html