search

AustEcon / bitsv

BitSV: Bitcoin made easy. Documentation:
https://AustEcon.github.io/bitsv
MIT License
97 stars 28 forks source link

Fix rates API using Bitfinex and freeforexapi. #33

Closed AustEcon closed 5 years ago

AustEcon commented 5 years ago

Hi @teran-mckinney

I've only done rudimentary testing but seems superficially at least to be working correctly. I put this together in a bit of a hurry so maybe you've got a nicer implementation or could recommend improvements to this one.

TTFN!

ghost commented 5 years ago

Re: failing tests, Bitindex needs to get this fixed. It's been a long time with broken CI tests.

Can we remove the STN tests for now? This code looks fine but it has a few consistency issues. If you fix only one thing I'd have it use the constant vs retyping the same URL and not using the constant.

AustEcon commented 5 years ago

Legend! I'll make all of those alterations and yes, quite happy to comment out the STN tests for now. Good idea.

PS: I only had 2 hours to get ^^ it done but thought it better to post what I had rather than sit on it and have duplication of work. 🤣

Cheers. I'll try to work on this after work.

ghost commented 5 years ago

Agreed, thanks for taking this on! :) Will be good to get it fixed.

AustEcon commented 5 years ago

I will go ahead and merge this now. That http://bitcoinsv-rates.com/ site is still down for me. I know you said it was working earlier though so I added it back again anyway (in series for redundancy). If it stays down for much longer (1 week - 2 weeks). I'd be favorable to commenting it out of the code or removing it because who knows who will be the new owner of that domain name if it ends up changing hands to somebody else...