search

AustEcon / bitsv

BitSV: Bitcoin made easy. Documentation:
https://AustEcon.github.io/bitsv
MIT License
96 stars 28 forks source link

Integrate BCHSVExplorer for mainnet, remove cashaddr, small cleanups, prep for 0.9.0 release #42

Closed ghost closed 5 years ago

ghost commented 5 years ago

This continues #39. Thank you AustEcon for doing the legwork here.

ghost commented 5 years ago

Thanks for your review! I've pushed changes to address most of what you had in mind. If you still think renaming the BchsSvExplorerWowThisIsLongDotCom class is worthwhile, I can do that.

ghost commented 5 years ago

Awesome, thank you Josh and AustEcon! I agree, test for get_transaction() is important.

I can rollback the version update in the code. I don't think it matters much because the git tag will show when it was cut and where. You can browse a git repo by a tag but not by the version in a file :).

That said, happy to adjust if need be.

AustEcon commented 5 years ago

No it's fine. I just wasnt sure about how the versioning worked so better to voice it than worry... 😆.

Let's merge!

ghost commented 5 years ago

Awesome, thank you!