search

AustEcon / bitsv

BitSV: Bitcoin made easy. Documentation:
https://AustEcon.github.io/bitsv
MIT License
96 stars 28 forks source link

Fix get_utxos() in https://github.com/AustEcon/whatsonchain #46

Closed AustEcon closed 3 years ago

AustEcon commented 5 years ago

I think it will not be too difficult to fix up whatsonchain such that it returns the number of confirmations and can therefore be compatible with bitsv's Unspents dataclass.

As per previous discussion...https://github.com/AustEcon/bitsv/pull/39#issuecomment-513504148

I think 2 function calls should be acceptable for this purpose... One to get current block height and another for the utxos --> calculate number of confirmations.

Once this is fixed we can finally add whatsonchain to main / test and stn as a second-line API for redundancy. Which I see as quite important.

ghost commented 5 years ago

That would be nice to have, for sure.

AustEcon commented 3 years ago

Fixed this ages ago in https://github.com/austecon/bitsv/commit/06013a7750d1e26e3198d09009fa9607b5668120

See WhatsonchainNormalised