search

AustEcon / bitsv

BitSV: Bitcoin made easy. Documentation:
https://AustEcon.github.io/bitsv
MIT License
96 stars 28 forks source link

Replace dead BitcoinSVRates with CryptoCompareRates #61

Closed ghost closed 4 years ago

ghost commented 4 years ago

This looks to be a good API and even allows Tor.

AustEcon commented 4 years ago

Thanks for the PR!

Will that endpoint work with no additional setup or does user need to go get a pubkey from website? If they do need a pubkey maybe we need an error message to instruct user of what to do. And could maybe have a function that sets an environment variable to the api key for hassle-free continued use.

Looks good though otherwise. If it works straight away without api key addition could merge as-is.

AustEcon commented 4 years ago

Okay - looks like (in FAQs) that they will support a free, public API for a limited time but will probably get worse over time. I can merge this now but might be another task for later to add a little function for tacking on a (free) api key (from their website) as an environment variable that gets added to the request header (if needed).

ghost commented 4 years ago

No problem! Thanks for looking into this.

It's working great for me so far. Been runnnig it on 10 servers, polling hourly, for a couple months now. Can definitely add API key support in the future if needed. bitcoinsvrates.com is dead anyways so should be a step in the right direction.

AustEcon commented 4 years ago

Awesome thanks 😃