search

AustEcon / bitsv

BitSV: Bitcoin made easy. Documentation:
https://AustEcon.github.io/bitsv
MIT License
96 stars 28 forks source link

change default fee from 1 to 0.5 sat/byte #62

Closed yoursmengle closed 4 years ago

yoursmengle commented 4 years ago

Change default fee from 1 to 0.5 sat/bytes

ghost commented 4 years ago

Default fee should be a constant with some kind of explanation.

I think this is a little ridiculous, IMO. Do we even support floats here?

AustEcon commented 4 years ago

Yes it should be one of the defaults like DEFAULT_FEE_SLOW from network.fees and I wasn't aware that the vast majority of miners on mainnet are now accepting 0.5 sat/byte tx fee - is that the case?

I'd rather stay conservative for default settings if not and keep it as 1 sat/byte otherwise people who don't understand what's going on will wonder why several blocks have passed and their tx is still not confirming...

AustEcon commented 4 years ago

I think we should support this feature though eventually (sub-1 sat/byte fees) but would require a bit of extra work to handle floats and round up the fee estimation to the nearest integer. Would also need tests.