search

AustEcon / bitsv

BitSV: Bitcoin made easy. Documentation:
https://AustEcon.github.io/bitsv
MIT License
96 stars 28 forks source link

bchsvexplorer: partially fix client #82

Closed kcentrifugal closed 3 years ago

kcentrifugal commented 3 years ago

This PR fixes the bchsvexplorer client partially, enough to pass current tests.

More time will be needed to fully bring it in line with the current API. But clearly no one is using this client-- is it worth the work?

kcentrifugal commented 3 years ago

unfortunately duplicating work of #78

but I think there are a few things this PR got right-- I'll comment on the other PR

ghost commented 3 years ago

At first glance looks good to me.

xloem commented 3 years ago

This differs from #78 because it doesn't include https://github.com/AustEcon/bitsv/pull/78/files#diff-94bb32bc0d347563bc1d3f5169d0c048fef96975c9d641dc96c7a0f324aa10b9R26 (the changed endpoint url) and hence connects to a different service. @kcentrifugal so you know, I emailed bchsvexplorer to ask about a query issue and they said that host is no longer maintained and the bsvbook.guarda service replaces it. That was some months ago. Sorry I haven't dealt with the concerns on my PR yet, feel free to favor this one or combine them or whatnot.

AustEcon commented 3 years ago

Thanks a million @kcentrifugal

Sorry for lagging behind on this... I have been trying to push another BSV project to its first milestone...

Will get onto this as soon as I can.

kcentrifugal commented 3 years ago

This differs from #78 because it doesn't include https://github.com/AustEcon/bitsv/pull/78/files#diff-94bb32bc0d347563bc1d3f5169d0c048fef96975c9d641dc96c7a0f324aa10b9R26 (the changed endpoint url) and hence connects to a different service.

No, https://bchsvexplorer.com/ and https://bsvbook.guarda.co/ are the same service on different domains. They serve the same content. Servers can respond to multiple domains. Anyway, I think it's a minor point.

AustEcon commented 3 years ago

Posting this here: https://github.com/guardaco/blockbook/blob/guarda-changes/docs/api.md

Because the documentation is not very easy to find with a simple google search...

xloem commented 3 years ago

maybe something changed since my support email, or i missed something. thanks for addressing this.