search

AustP / git-go

A drop down terminal and commonly used git commands available from the "get-go".
MIT License
3 stars 1 forks source link

Fix code deprecations #2

Closed supergithubo closed 9 years ago

supergithubo commented 9 years ago

Fix some deprecated codes showing up on the editor

Atom deprecation warnings:

Use ::getRepositories instead

Project.getRepo (<PATH>\AppData\Local\atom\app-0.189.0\resources\app\src\project.js:189:12)
ChildProcess.<anonymous> (<PATH>\.atom\packages\git-go\lib\console.coffee:400:43)

Use ::getPaths instead

Project.getPath (<PATH>\AppData\Local\atom\app-0.189.0\resources\app\src\project.js:235:12)
Object.initialize (<PATH>\.atom\packages\git-go\lib\console.coffee:158:24)
AustP commented 9 years ago

Thanks for your PR!

With the latest changes to Atom that allows multiple projects in the editor, I wonder how that will affect us.

For making sure the repositories' status are up to date, we may have to loop through all of them and call refreshStatus for each of them.

Getting the current working directory is a bit trickier. Perhaps its fine for us to just get the path of the first project, and have the users deal with it using cd in the terminal.

In any case, thanks for bringing this to my attention. =)