search

Austin-DSA / Membership-Engagment-Tools

GNU Affero General Public License v3.0
3 stars 1 forks source link

Suggestions #9

Closed bmos closed 7 months ago

bmos commented 7 months ago

I have not tested this as I don't have access to the data + APIs.

Just some friendly suggestions. Take them or leave them. Sorry if the line length/formatting goes too far into the personal preference realm, if so I can resubmit without that one.

Next steps I'd suggest would be adding docstrings throughout.

matorin57 commented 7 months ago

Overall like the suggestions. I do have some specific comments however one of them could be a line length thing. I personally don't like line length guidelines too much as I've read some C++ where the line length requirement really messed with me. However I'm also normally in the Obj-C world which is very verbose and has very long lines (even when formatting to not have them).

bmos commented 7 months ago

I personally don't like line length guidelines too much as I've read some C++ where the line length requirement really messed with me.

I'll roll that one back, in looking it over this morning I tend to agree it's a mixed result for legibility in some places