search

AustinGil / bedrocss

A classless CSS library that's modern, lightweight, and easy to modify so you can start your projects on a solid foundation. It does a bit more than a reset, but not so much as a framework. bedrocss applies sane defaults to plain HTML elements, so there isn't anything to learn, and it's super easy to modify.
https://bedrocss.austingil.com/
29 stars 4 forks source link

Should table use :where? #12

Open roblevintennis opened 2 years ago

roblevintennis commented 2 years ago

I'm wondering if https://github.com/AustinGil/bedrocss/blob/master/src/base.css#L65 should use :where(table) so that folks that want to for some reason override this benefit from the zero specificity? I suppose IE support becomes an issue but you've already elected to use :where so I'm presuming you're targeting A grade.

It's interesting to see Addam Argyle using the heck out of this: https://github.com/argyleink/open-props/blob/main/src/extra/normalize.css

AustinGil commented 2 years ago

I think the only time that would make a difference is if custom styles are imported before this library, but this is intended to be a reset, so it should come first. If that's the case, then any custom styles to table would override this library due to the cascade.

But, maybe it's a good idea so it doesn't matter what order it's imported in.

roblevintennis commented 2 years ago

I think the easier it is to override the better unless you're trying to "lock down" a class like in the case of a css utility class which folks put important on.

These are really small nitpicks I hope you don't mind! I learned a lot looking at these files!

roblevintennis commented 2 years ago

Also closing as it's of course very small and your discretion on if the feedback is actionable or not. Thanks for the dialogue 👍🏽

AustinGil commented 2 years ago

Hey Rob, circling back on this. I like the feedback. Please continue to do so as you see fit. I'm definitely not right in all my decisions and it's good to have someone asking about them. I may yet consider adding the :where clause, but that would also suggest that I add it to every class. It's probably not a ton of overhead, but I want to think on it more before I do. In the sort term, I think it's worth just asking folks to import this library before any others, but if we want to add more flexibility, then that would be a good approach.