AustinGil / vuetensils

🍴 A tasty toolset for Vue.js 🛠 - Lightweight, functional components to boost your next project.
https://vuetensils.austingil.com/
MIT License
661 stars 38 forks source link

A11y automated testing #79

Closed TheJaredWilcurt closed 4 years ago

TheJaredWilcurt commented 4 years ago
AustinGil commented 4 years ago

Yeah, this is a good idea. I've got some local a11y linters set up which catch stuff locally, but if more folks start contributing then integrated a11y linting on commit would be a good step, and then in CI/CD is even better.

Great idea!

TheJaredWilcurt commented 4 years ago

I'm pretty strongly against tying anything into git hooks. It just breaks too many git GUI's, and it forces people with different workflows into something that may be inconvenient. Just having a CI run the check is fine. As long as you can't merge to master until those are fixed, it doesn't matter if it's done on every commit, or just once on the last commit.