search

Austinb / GameQ

A PHP Gameserver Status Query Library
https://austinb.github.io/GameQ/
GNU Lesser General Public License v3.0
404 stars 137 forks source link

Two protocol classes for rFactor 2 #681

Open Krymonota opened 2 years ago

Krymonota commented 2 years ago

Currently, there's already the Rf2 protocol class for rFactor2. However, in #662 another protocol class for rFactor 2 was added: Rfactor2

Since there has been no release with the Rfactor2 class yet, I would vouch for removing it again.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Krymonota commented 1 year ago

Not stale

Austinb commented 1 year ago

The class Rfactor2 does not work out of the box for me. Does it work for any servers? I tested servers from https://fun4all.lt/serverlist/rF2.php and none of them worked for the Rfactor2 version.

Thoughts are to make Rfactor2 the correct version using Rf2 as the base and then just make Rf2 and extension of Rfactor2. Also should strip any of the Rfactor2 credits as the class does not work and is a duplicate. Need to make sure we are not duplicating classes due to name changes.

Krymonota commented 1 year ago

If you want to handle it this way, I'd like to add that the Rf2 should be marked as deprecated in favor of Rfactor2 then so that it can be safely removed in a future version.

As for functionality: I haven't tested it, and I'm not aware of any Rfactor(2) servers personally (apart from the public ones you've found), so I can't say anything about that.

Austinb commented 1 year ago

That is perfectly fine. Just dont want to break things instantly with these changes.

Erani0 commented 1 year ago

Hello, I don't know where there is a problem. So I didn't pay attention to whether there was already a log, so I added it for Rfactor and Rfactor2 and also made corresponding tests, which can also be viewed. I don't understand why there is a big problem there gives

All Two versions works!!!

With Server from The list. {"51.79.205.0:64297":{"dedicated":"l","game_descr":"rFactor 2","game_dir":"rFactor 2","game_id":365960,"gq_address":"51.79.205.0","gq_dedicated":"l","gq_gametype":"rFactor 2","gq_hostname":"PEA and Partners","gq_joinlink":"steam:\/\/connect\/51.79.205.0:64297\/","gq_mapname":"Kyalami Endurance","gq_maxplayers":31,"gq_mod":"rFactor 2","gq_name":"rFactor 2","gq_numplayers":3,"gq_online":true,"gq_password":1,"gq_port_client":64297,"gq_port_query":64299,"gq_protocol":"source","gq_transport":"udp","gq_type":"rf2","hostname":"PEA and Partners","map":"Kyalami Endurance","max_players":31,"num_bots":0,"num_players":3,"os":"w","password":1,"players":[],"port":-1239,"protocol":17,"secure":0,"steam_id":90170569642639366,"steamappid":0,"teams":[],"version":"11132"}}

@Austinb feel free to delete rfactor 2 from me so @Krymonota is happy.

I've never added anything that doesn't work and it seemed like it was lost the RF2 Rfactor 2 is so I thought I'd add it