Austintjh19 / pe

0 stars 0 forks source link

Allowing Invalid Email Address. #8

Open Austintjh19 opened 1 month ago

Austintjh19 commented 1 month ago

Allow entry of test@example for an email. Does not contain a top level domain which does not make sense for an email.

image.png

soc-se-bot commented 3 weeks ago

Team's Response

This is the same issue pertaining to the argument of TLD, as per #3578.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid emails allowed

The program allows me to enter the email a@bc, which is an invalid email, since there is no TLD.

image.png


[original: nus-cs2103-AY2324S2/pe-interim#4505] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We do not restrict the domain name heavily to allow for user's to be more flexible with their domain name. The restrictions / leniency regarding email inputs has also been reflected in the UG. Additionally, TLD is also not required for a email to be valid, as discussed here.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Source provided does not really disprove that emails do not need a top level domain. I.e. end with .something Although reflected in UG, it doesn't make sense to allow for invalid email entries given that this is an addressbook application.