Australian-Imaging-Service / xnat4tests

A Python module that stands up a basic XNAT repository in a single Docker container to be used in testing pipelines interact with the XNAT API and/or container service
Other
5 stars 4 forks source link

Àdd extra exception to catch to deal with a change in XNATpy which al… #16

Closed hachterberg closed 12 months ago

hachterberg commented 1 year ago

XNATpy now allows the initially requests to time out to avoid the possibility of hanging indefinitely (see https://gitlab.com/radiology/infrastructure/xnatpy/-/commit/288df3149c8e88701d3375ae075e55d9bf2bc980). This can cause the exception raised by XNATpy when the connection cannot be made to change and trigger the exception breaking xnat4tests here. By adding the extra exception to be caught everything works fine again.

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9fe48c4) 83.95% compared to head (3896952) 83.95%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16 +/- ## ======================================= Coverage 83.95% 83.95% ======================================= Files 7 7 Lines 399 399 Branches 47 47 ======================================= Hits 335 335 Misses 53 53 Partials 11 11 ``` | [Files](https://app.codecov.io/gh/Australian-Imaging-Service/xnat4tests/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Australian-Imaging-Service) | Coverage Δ | | |---|---|---| | [xnat4tests/base.py](https://app.codecov.io/gh/Australian-Imaging-Service/xnat4tests/pull/16?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Australian-Imaging-Service#diff-eG5hdDR0ZXN0cy9iYXNlLnB5) | `74.50% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.