AustralianAntarcticDivision / SOmap

Southern Ocean round maps
https://australianantarcticdivision.github.io/SOmap/
24 stars 6 forks source link

ggplotting #24

Closed raymondben closed 4 years ago

raymondben commented 5 years ago

Just a placeholder for notes:

Maschette commented 5 years ago

Hey @raymondben just checking, the SOgg function will currently print the base map for everything except the legend? and then I notice the code has some of the layers in it, are these working too?

raymondben commented 5 years ago

Yeah, I didn't get around to some layers at the time (SSRU/SSMU/CCAMLR/SPRFMO/RB). I will get back to this, including the note above (i.e. SOgg will convert a SOmap object that uses base/raster plotting calls to an object that uses ggplot calls; the print and plot methods for that new object will then evaluate those calls and return an actual ggplot object, which can then be displayed using the usual print.ggplot method)

Maschette commented 5 years ago

So I have everything working except for: SSMUlabs (see other issue), Domainslab, IWC and IWClab.

Also the more I think about it the more I am unsure about making SOauto_map on ggplot but thats a different days issue.

raymondben commented 5 years ago

SSMUlabs, Domainslab, IWC, IWClab now working, sorta. Probably need to revisit all of the ggplotting code as things evolve but for now probably ok

Maschette commented 4 years ago

Can we close this now @raymondben?

raymondben commented 4 years ago

closing this, it's just a general gg-related placeholder for which we now have some more specific tasks (and no doubt more to come)