search

AustralianAntarcticDivision / SOmap

Southern Ocean round maps
https://australianantarcticdivision.github.io/SOmap/
24 stars 6 forks source link

SOgg in dev-06 #84

Closed Maschette closed 4 years ago

Maschette commented 4 years ago

I will post a full reprex with the error codes when I finish very gentleR but the dev-06 version is throwing an error with: 

myplot <- SOmap()
myplotgg <- SOgg(myplot)

I think it is something to do with how it does the bathymetry legend. The master branch works fine, any thoughts @raymondben?

raymondben commented 4 years ago

Hum. Something sure got out of whack there. Possibly fixed by https://github.com/AustralianAntarcticDivision/SOmap/commit/548d72834004842c54c7c7d355ebaafa5d72cb62, but I will put time aside early next week to look over the dev branch more fully.

raymondben commented 4 years ago

I think we are all good. Made various small additional fixes that should improve visual consistency between the non-gg and gg version of a map.