AustralianAntarcticDivision / raadtools

Tools for Synoptic Environmental Spatial Data
http://australianantarcticdivision.github.io/raadtools/
24 stars 3 forks source link

readcurr() upgrade #132

Open mdsumner opened 1 year ago

mdsumner commented 1 year ago

All the Copernicus altimetry is now more consistent with file and read functions for "adt/err/ugos/vgos/ugos/vgosa", so I'm inclined to change readcurr. We could remove the uonly/vonly args, point to read_ugos/vgos, and leave the magonly/dironly options.

I'd like to remove readcurr() from returning two layers, and being unable to return a time series.

So, maybe

changes are in https://github.com/AustralianAntarcticDivision/raadtools/blob/gdal-new-world/R/copernicus_altimetry.R

mdsumner commented 1 year ago

now done in readcurr() 83c2991e8461a3de8e4ac1f510e2a6f6a6cb03ee it can still return 2 layers for one time step, but points to the new versions

More details are in the NEWs, where I'll collate learnings as we go.

will leave this open for extra checks, but read/extract/xylim all working as expected (we're handling the pacific/atlantic thing in the conversoin of fullname to vrt_dsn as a special case, later we'lldo that with "vrt://" and a look up (because no need to template a big string replace).)