search

AustralianCancerDataNetwork / pydicer

PYthon Dicom Image ConvertER
https://australiancancerdatanetwork.github.io/pydicer/
Apache License 2.0
20 stars 4 forks source link

WIP: Add pylintrc and make pylint pass #34

Closed pchlap closed 2 years ago

pchlap commented 2 years ago

Hi @dalmouiee, I've tweaked the pylint config a bit. I've added the pylintrc file which is commonly used to configure pylint. Now everything will flag, except for the checks we explicitly set as disabled in there. Like this is transparent what we require as far as linting goes, and the same things will flag in your VSCode editor as in the github pipelines.

I'd be curious to hear what you think. We can also discuss this in the Friday meeting to see what everyone things should be included/excluded from pylint checks.

I also made a few small changes to the FileSystemInput class. Would be good if you could review to that too :)

pchlap commented 2 years ago

I've merged through the main branch, and made a couple of corrections to make pylint happy. Won't merge this PR just yet, will do that in Friday's meeting :)